Skip to content

switch readline to libedit - #919

Merged
henderkes merged 15 commits into
mainfrom
libedit
Oct 15, 2025
Merged

switch readline to libedit#919
henderkes merged 15 commits into
mainfrom
libedit

Conversation

@henderkes

@henderkes henderkes commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

switch readline to libedit backend so we don't force gpl-3 license on users

closes #918
closes #888

@henderkes
henderkes requested a review from crazywhalecc October 8, 2025 07:47

@crazywhalecc crazywhalecc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to remove SPC_CMD_PREFIX_PHP_MAKE? The rest looks good to me.

@henderkes

Copy link
Copy Markdown
Collaborator Author

Just a continuation of slimming down env.ini. Optimally, we only want to expose env variables that would make sense to change as a user. The make command doesn't make sense to change.

@henderkes
henderkes merged commit 487c6da into main Oct 15, 2025
11 checks passed
@henderkes
henderkes deleted the libedit branch October 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: lib_libiconv_0 contains GPL-3 license instead of LGPL Precompiled Musl PHP Binaries don't support php -a

2 participants